add cli option for log formatting (Closes #531) #784
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / Why we need it:
this pr adds an option to chose between the following formatting option:
auto
- default option, detects if running in an interactive terminal and will choose either "json" or "plain"json
- outputs logs in jsonplain
- uses default tracing_subscriber outputpretty
- uses tracing_subscriber.pretty() outputHow the options look
json
plain
pretty
Which issue(s) this PR fixes:
Closes #531
Special notes for your reviewer:
Not sure about the naming, "detect" could also be "auto" or if "pretty" should be something like "debug". I am also not sure if the "ppretty" option is needed at all.updated with renamed options