Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move more logs to debug #796

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Move more logs to debug #796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/xds/client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ impl<C: ServiceClient> Client<C> {
let client = connect_to_server
.instrument(tracing::trace_span!("client_connect"))
.await?;
tracing::info!("Connected to relay server");
tracing::info!("Connected to management server");
Ok(client)
}
}
Expand Down Expand Up @@ -395,7 +395,7 @@ impl MdsStream {
let mut stream = control_plane.stream_aggregated_resources(stream).await?;
while let Some(result) = stream.next().await {
let response = result?;
tracing::info!(config=%serde_json::to_value(&config).unwrap(), "received discovery response");
tracing::debug!(config=%serde_json::to_value(&config).unwrap(), "received discovery response");
requests.send(response)?;
}

Expand Down Expand Up @@ -506,7 +506,7 @@ pub fn handle_discovery_responses(
) -> std::pin::Pin<Box<dyn futures::Stream<Item = Result<DiscoveryRequest>> + Send>> {
Box::pin(async_stream::try_stream! {
let _stream_metrics = super::metrics::StreamConnectionMetrics::new(identifier.clone());
tracing::info!("awaiting response");
tracing::debug!("awaiting response");
for await response in stream
{
let response = match response {
Expand All @@ -520,7 +520,7 @@ pub fn handle_discovery_responses(
let control_plane_identifier = response.control_plane.as_ref().map(|cp| cp.identifier.clone()).unwrap_or_default();

super::metrics::discovery_responses(&control_plane_identifier, &response.type_url).inc();
tracing::info!(
tracing::debug!(
version = &*response.version_info,
r#type = &*response.type_url,
nonce = &*response.nonce,
Expand All @@ -534,7 +534,7 @@ pub fn handle_discovery_responses(
.map(Resource::try_from)
.try_for_each(|resource| {
let resource = resource?;
tracing::info!("applying resource");
tracing::debug!("applying resource");
(on_new_resource)(&resource)
});

Expand Down
2 changes: 1 addition & 1 deletion src/xds/server.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ impl ControlPlane {
// Currently just resend previous discovery response.
} else if uuid::Uuid::parse_str(&new_message.response_nonce).is_ok() {
if pending_acks.cache_get(&new_message.response_nonce).is_some() {
tracing::info!(nonce = %new_message.response_nonce, "ACK");
tracing::debug!(nonce = %new_message.response_nonce, "ACK");
continue
} else {
tracing::trace!(nonce = %new_message.response_nonce, "Unknown nonce: could not be found in cache");
Expand Down