Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: Update readiness and liveness checks. #821

Merged
merged 1 commit into from
Oct 14, 2023

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

/kind feature

/kind hotfix

What this PR does / Why we need it:

This adds readiness checks to the xds and relay examples, and updates the liveness checks to be more aggressive than their previous configuration.

Which issue(s) this PR fixes:

Closes #818

Special notes for your reviewer:

Also fixed a small formatting issue in the admin docs (newline between tables).

This adds readiness checks to the xds and relay examples, and updates
the liveness checks to be more aggressive than their previous
configuration.

Also fixed a small formatting issue in the admin docs (newline between
tables).

Closes googleforgames#818
@markmandel markmandel added the area/examples Examples. Usually found in the `examples` directory label Oct 13, 2023
@markmandel markmandel mentioned this pull request Oct 13, 2023
41 tasks
@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 17b11979-2410-4269-9e86-94a40e21c713

The following development images have been built, and will exist for the next 30 days:

To build this version:

git fetch [email protected]:googleforgames/quilkin.git pull/821/head:pr_821 && git checkout pr_821
cargo build

@XAMPPRocky XAMPPRocky merged commit cdd3e82 into googleforgames:main Oct 14, 2023
3 checks passed
@markmandel markmandel deleted the examples/readiness branch October 17, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/examples Examples. Usually found in the `examples` directory size/s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add readiness checks to /examples
3 participants