-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various improvements based on loadtests #836
Conversation
This is to prevent heavy load on the main tasks from saturating the workload and causing the admin server to become unresponsive, then triggering a termination from Kubernetes.
When measured it seems we wasting more time with moving memory into the task than we gained from having it be its own task.
242c814
to
7941c33
Compare
Further improvements on getting the number of endpoints for each packet, this time the value is cached, this should save us some expensive Arc::drops from dashmap.
7941c33
to
74290d6
Compare
19b8432
to
2e9fd95
Compare
9dbd5dc
to
2965eaa
Compare
2965eaa
to
7cc17d1
Compare
I'm at a conference today/tomorrow - but I can have a look at why the Agones test is failing when I get back, if that's useful. |
I assume this is more of a WIP PR, than something you want review on? Just wanted to check real quick. |
Correct, this is just a collection of the changes I've made it to make it handle load better, it's all in one PR right now to make it easy to pull an image. Once I have more time the goal is to cherry-pick individual commits into their own PRs so they can each be reviewed separately. |
f5f76f5
to
a541ce3
Compare
a541ce3
to
3d04dad
Compare
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
Build Failed 😭 Build Id: cb554697-3035-42ad-98e0-3b2b28f4ea4b Status: FAILURE To get permission to view the Cloud Build view, join the quilkin-discuss Google Group. Filter with the Git Commit Development images are retained for at least 30 days. |
A continuation of #777 this contains various improvements based on loadtests. This is separated because I attempted to add io-uring to #777 and would like to be able to have both images available (if I can ever get io-uring to compile).