Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various improvements based on loadtests #836

Closed
wants to merge 18 commits into from

Conversation

XAMPPRocky
Copy link
Collaborator

A continuation of #777 this contains various improvements based on loadtests. This is separated because I attempted to add io-uring to #777 and would like to be able to have both images available (if I can ever get io-uring to compile).

This is to prevent heavy load on the main tasks from saturating the
workload and causing the admin server to become unresponsive, then
triggering a termination from Kubernetes.
When measured it seems we wasting more time with moving memory into the
task than we gained from having it be its own task.
Further improvements on getting the number of endpoints for each packet,
this time the value is cached, this should save us some expensive
Arc::drops from dashmap.
@XAMPPRocky XAMPPRocky force-pushed the ep/retain-endpoints-backup branch from 7941c33 to 74290d6 Compare October 23, 2023 01:37
@XAMPPRocky XAMPPRocky force-pushed the ep/retain-endpoints-backup branch from 19b8432 to 2e9fd95 Compare October 23, 2023 04:49
@XAMPPRocky XAMPPRocky force-pushed the ep/retain-endpoints-backup branch from 9dbd5dc to 2965eaa Compare October 23, 2023 17:58
@XAMPPRocky XAMPPRocky force-pushed the ep/retain-endpoints-backup branch from 2965eaa to 7cc17d1 Compare October 23, 2023 18:20
@markmandel
Copy link
Member

I'm at a conference today/tomorrow - but I can have a look at why the Agones test is failing when I get back, if that's useful.

@markmandel
Copy link
Member

I assume this is more of a WIP PR, than something you want review on?

Just wanted to check real quick.

@XAMPPRocky
Copy link
Collaborator Author

I assume this is more of a WIP PR, than something you want review on?

Correct, this is just a collection of the changes I've made it to make it handle load better, it's all in one PR right now to make it easy to pull an image. Once I have more time the goal is to cherry-pick individual commits into their own PRs so they can each be reviewed separately.

@XAMPPRocky XAMPPRocky force-pushed the ep/retain-endpoints-backup branch from f5f76f5 to a541ce3 Compare October 28, 2023 15:15
@XAMPPRocky XAMPPRocky force-pushed the ep/retain-endpoints-backup branch from a541ce3 to 3d04dad Compare October 28, 2023 16:32
@github-actions github-actions bot removed the size/l label Oct 31, 2023
@github-actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@quilkin-bot
Copy link
Collaborator

Build Failed 😭

Build Id: cb554697-3035-42ad-98e0-3b2b28f4ea4b

Status: FAILURE

To get permission to view the Cloud Build view, join the quilkin-discuss Google Group.

Filter with the Git Commit be7159f within us-docker.pkg.dev/quilkin/ci//quilkin to see if a development image is available from this build, and can be used for debugging purposes.

Development images are retained for at least 30 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants