Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initial unit tests for dedicated and protostream #44

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Add initial unit tests for dedicated and protostream #44

merged 1 commit into from
Feb 13, 2024
+112 −1

Conversation

miledxz
Copy link
Contributor

@miledxz miledxz commented Feb 9, 2024

Regarding this issue: #1,

Im adding initial pr, to improve test coverage,

if this seems good, I can add more test coverage in another pr

gentle ping for @govargo

@govargo govargo self-requested a review February 13, 2024 08:18
govargo
govargo approved these changes Feb 13, 2024
View reviewed changes
Copy link
Collaborator

@govargo govargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you zedGGs!

Thank you to this contribution, our test coverage was increased!!

I can add more test coverage in another pr

I'm also looking forward to another PR.
Thank you.

@govargo govargo merged commit e189bf1 into googleforgames:main Feb 13, 2024
5 checks passed
@govargo govargo mentioned this pull request Jul 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@govargo govargo govargo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miledxz @govargo