Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: customize MarkerInfoWindow's Marker using Composable #384

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

mosmb
Copy link
Contributor

@mosmb mosmb commented Aug 21, 2023

Add Composable support for Marker inside MakerInfoWindow

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #383 🦕

@mosmb
Copy link
Contributor Author

mosmb commented Sep 26, 2023

hi @wangela
any news for this one?

@wangela wangela requested a review from kikoso October 6, 2023 16:14
@kikoso
Copy link
Collaborator

kikoso commented Jan 9, 2024

Hi @mosmb ,

Could you add a small sample in the BasicMapActivity? Just a MarkerInfoWindow somewhere.

@kikoso
Copy link
Collaborator

kikoso commented Oct 16, 2024

Hi @mosmb . Did you have the chance to take a look at the comment above? With the sample we should be able to merge the PR.

@mosmb
Copy link
Contributor Author

mosmb commented Oct 16, 2024

Ooops completely forgot about this, will do ! @kikoso

@mosmb mosmb force-pushed the composable-markerinfowindow branch from b95cf3f to 3117468 Compare October 16, 2024 13:50
@kikoso
Copy link
Collaborator

kikoso commented Oct 16, 2024

Hi @mosmb. It seems that your commit went under an address that did not sign the CLA:

https://github.com/googlemaps/android-maps-compose/pull/384/checks?check_run_id=31618939418

@mosmb
Copy link
Contributor Author

mosmb commented Oct 16, 2024

@kikoso
Done, should be good now.
Do not hesitate if you have any feedbacks.
CLA check failed because I changed my GitHub name and forgot to submit a new one, it's done now.

@mosmb
Copy link
Contributor Author

mosmb commented Oct 22, 2024

ping @kikoso

@kikoso
Copy link
Collaborator

kikoso commented Oct 22, 2024

Hi @mosmb ! We will take a look at this next week, thanks for putting it together.

@dkhawk dkhawk merged commit 6dfe858 into googlemaps:main Oct 29, 2024
10 of 11 checks passed
googlemaps-bot pushed a commit that referenced this pull request Oct 29, 2024
# [6.2.0](v6.1.2...v6.2.0) (2024-10-29)

### Features

* customize MarkerInfoWindow's Marker using Composable ([#384](#384)) ([6dfe858](6dfe858))
@googlemaps-bot
Copy link
Contributor

🎉 This PR is included in version 6.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Composable for MarkerInfoWindow
5 participants