fix: make DefaultMapProperties, DefaultMapUiSettings, and NoPadding public #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kikoso
changed the title
kikoso
approved these changes
Apr 23, 2024
kikoso
requested changes
Apr 23, 2024
There was a problem hiding this comment.
Hi @bubenheimer . This looks good. Could we add some documentation to each field, since they become public?
bubenheimer
force-pushed
the
make_default_objects_public
branch
from
7b29de1 to
0e4782b
Compare
|
Thanks, @kikoso. I added documentation and renamed nondescript top level |
Add documentation for DefaultMapProperties, DefaultMapUiSettings, and DefaultMapContentPadding
bubenheimer
force-pushed
the
make_default_objects_public
branch
from
0e4782b to
3940ff5
Compare
|
🎉 This PR is included in version 5.0.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #513