Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: not adding by default the MapColorScheme #603

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

kikoso
Copy link
Collaborator

@kikoso kikoso commented Jul 9, 2024

The following PR removes the default value for MapColorScheme, which conflicts with the tile mode.


Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #601 🦕

@kikoso kikoso marked this pull request as ready for review July 9, 2024 19:04
@googlemaps-bot
Copy link
Contributor

Code Coverage

Overall Project 21.77%

There is no coverage information present for the Files changed

@dkhawk dkhawk changed the title fix: not adding by default the MapColorScheme chore: not adding by default the MapColorScheme Jul 9, 2024
@dkhawk dkhawk merged commit b5cee56 into main Jul 9, 2024
11 checks passed
@dkhawk dkhawk deleted the fix/map_color_without_default_assignment branch July 9, 2024 19:49
@googlemaps-bot
Copy link
Contributor

🎉 This issue has been resolved in version 6.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lite mode crash in 6.0.0
3 participants