Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: location tracking activity to component activity #617

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

dkhawk
Copy link
Contributor

@dkhawk dkhawk commented Aug 27, 2024

Update the LocationTrackingActivity to be a ComponentActivity to make it consistent.

dkhawk and others added 3 commits August 27, 2024 17:21
* fix: enable edge-to-edge in sample

https://developer.android.com/develop/ui/views/layout/edge-to-edge

* fix: changes MarkerClusteringActivity to use a Box vs a Surface which interfaces with map touch events

---------

Co-authored-by: dkhawk <[email protected]>
# Conflicts:
#	app/src/main/java/com/google/maps/android/compose/LocationTrackingActivity.kt
@dkhawk dkhawk requested a review from kikoso August 27, 2024 23:39
@Goooler
Copy link
Contributor

Goooler commented Aug 27, 2024

And we can migrate the theme to not using AppCompat to fully get rid of AppCompat.

android:theme="@style/Theme.AndroidMapsCompose" >


Edit: addressing the fix to #620.

@googlemaps-bot
Copy link
Contributor

Code Coverage

Overall Project 18.65% -0.07%
Files changed 0%

File Coverage
LocationTrackingActivity.kt 0% -1.96%

@kikoso kikoso changed the title Fix/location tracking activity to component activity fix: location tracking activity to component activity Aug 28, 2024
Copy link
Collaborator

@kikoso kikoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we do not need the AppCompatActivity.

@kikoso kikoso self-assigned this Aug 28, 2024
@dkhawk dkhawk merged commit a9d2fb5 into main Aug 28, 2024
11 checks passed
@dkhawk dkhawk deleted the fix/location-tracking-activity-to-component-activity branch August 28, 2024 18:28
googlemaps-bot pushed a commit that referenced this pull request Aug 28, 2024
## [6.1.3](v6.1.2...v6.1.3) (2024-08-28)

### Bug Fixes

* location tracking activity to component activity ([#617](#617)) ([a9d2fb5](a9d2fb5)), closes [#614](#614)
@googlemaps-bot
Copy link
Contributor

🎉 This issue has been resolved in version 6.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

googlemaps-bot pushed a commit that referenced this pull request Sep 3, 2024
## [6.1.2](v6.1.1...v6.1.2) (2024-09-03)

### Bug Fixes

* enable edge-to-edge in sample ([#614](#614)) ([a87a3b0](a87a3b0))
* location tracking activity to component activity ([#617](#617)) ([a9d2fb5](a9d2fb5)), closes [#614](#614)
@googlemaps-bot
Copy link
Contributor

🎉 This PR is included in version 6.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants