chore: Change the confusing parameter position to a clear name. #637

app/src/main/java/com/google/maps/android/compose/AccessibilityActivity.kt

@@ -37,7 +37,7 @@ class AccessibilityActivity : ComponentActivity() {
         super.onCreate(savedInstanceState)
         enableEdgeToEdge()
         setContent {
-            val singaporeState = rememberMarkerState(position = singapore)
+            val singaporeState = rememberMarkerState(initialPosition = singapore)
             val cameraPositionState = rememberCameraPositionState {
                 position = defaultCameraPosition
             }

app/src/main/java/com/google/maps/android/compose/BasicMapActivity.kt

@@ -142,11 +142,11 @@ fun GoogleMapView(
     mapColorScheme: ComposeMapColorScheme = ComposeMapColorScheme.FOLLOW_SYSTEM,
     content: @Composable () -> Unit = {}
 ) {
-    val singaporeState = rememberMarkerState(position = singapore)
-    val singapore2State = rememberMarkerState(position = singapore2)
-    val singapore3State = rememberMarkerState(position = singapore3)
-    val singapore4State = rememberMarkerState(position = singapore4)
-    val singapore5State = rememberMarkerState(position = singapore5)
+    val singaporeState = rememberMarkerState(initialPosition = singapore)
+    val singapore2State = rememberMarkerState(initialPosition = singapore2)
+    val singapore3State = rememberMarkerState(initialPosition = singapore3)
+    val singapore4State = rememberMarkerState(initialPosition = singapore4)
+    val singapore5State = rememberMarkerState(initialPosition = singapore5)
 
     var circleCenter by remember { mutableStateOf(singapore) }
     if (!singaporeState.isDragging) {

app/src/main/java/com/google/maps/android/compose/MapInColumnActivity.kt

@@ -185,7 +185,7 @@ private fun GoogleMapViewInColumn(
     cameraPositionState: CameraPositionState,
     onMapLoaded: () -> Unit,
 ) {
-    val singaporeState = rememberMarkerState(position = singapore)
+    val singaporeState = rememberMarkerState(initialPosition = singapore)
 
     var uiSettings by remember { mutableStateOf(MapUiSettings(compassEnabled = false)) }
     var mapProperties by remember {

app/src/main/java/com/google/maps/android/compose/RecompositionActivity.kt

@@ -70,7 +70,7 @@ class RecompositionActivity : ComponentActivity() {
         cameraPositionState: CameraPositionState = rememberCameraPositionState(),
         content: @Composable () -> Unit = {},
     ) {
-        val markerState = rememberMarkerState(position = singapore)
+        val markerState = rememberMarkerState(initialPosition = singapore)
 
         val uiSettings by remember { mutableStateOf(MapUiSettings(compassEnabled = false)) }
         val mapProperties by remember {

app/src/main/java/com/google/maps/android/compose/markerexamples/AdvancedMarkersActivity.kt

@@ -70,10 +70,10 @@ class AdvancedMarkersActivity : ComponentActivity(), OnMapsSdkInitializedCallbac
             val mapProperties by remember {
                 mutableStateOf(MapProperties(mapType = MapType.NORMAL))
             }
-            val marker1State = rememberMarkerState(position = santiago)
-            val marker2State = rememberMarkerState(position = bogota)
-            val marker3State = rememberMarkerState(position = lima)
-            val marker4State = rememberMarkerState(position = salvador)
+            val marker1State = rememberMarkerState(initialPosition = santiago)
+            val marker2State = rememberMarkerState(initialPosition = bogota)
+            val marker3State = rememberMarkerState(initialPosition = lima)
+            val marker4State = rememberMarkerState(initialPosition = salvador)
 
             // Drawing on the map is accomplished with a child-based API
             val markerClick: (Marker) -> Boolean = {

app/src/main/java/com/google/maps/android/compose/markerexamples/MarkerClusteringActivity.kt

@@ -118,7 +118,7 @@ fun GoogleMapClustering(items: List<MyItem>) {
         }
 
         MarkerInfoWindow(
-            state = rememberMarkerState(position = singapore),
+            state = rememberMarkerState(initialPosition = singapore),
             onClick = {
                 Log.d(TAG, "Non-cluster marker clicked! $it")
                 true

app/src/main/java/com/google/maps/android/compose/markerexamples/markerdragevents/MarkerDragEventsActivity.kt

@@ -87,7 +87,7 @@ private fun DraggableMarker(
     onDrag: (LatLng) -> Unit = {},
     onDragEnd: () -> Unit = {}
 ) {
-    val markerState = rememberMarkerState(position = singapore)
+    val markerState = rememberMarkerState(initialPosition = singapore)
 
     Marker(
         state = markerState,

app/src/main/java/com/google/maps/android/compose/markerexamples/updatingnodragmarkerwithdatamodel/UpdatingNoDragMarkerWithDataModelActivity.kt

@@ -152,6 +152,6 @@ fun rememberUpdatedMarkerState(position: LatLng): MarkerState =
     // rememberUpdatedState() uses MutableState, we use MarkerState.
     // This is more efficient than updating position in an effect,
     // as we avoid an additional recomposition.
-    remember { MarkerState(position = position) }.also {
+    remember { MarkerState(initialPosition = position) }.also {
         it.position = position
     }

maps-compose/src/main/java/com/google/maps/android/compose/Marker.kt

@@ -155,12 +155,12 @@ public class MarkerState private constructor(position: LatLng) {
         /**
          * Creates a new [MarkerState] object
          *
-         * @param position the initial marker position
+         * @param initialPosition the initial marker position
          */
         @StateFactoryMarker
         public operator fun invoke(
-            position: LatLng = LatLng(0.0, 0.0)
-        ): MarkerState = MarkerState(position)
+            initialPosition: LatLng = LatLng(0.0, 0.0)
+        ): MarkerState = MarkerState(initialPosition)
 
         /**
          * The default saver implementation for [MarkerState]
@@ -182,13 +182,15 @@ public class MarkerState private constructor(position: LatLng) {
  * Other use cases may be better served syncing [MarkerState.position] with a data model.
  *
  * This cannot be used to preserve info window visibility across configuration changes.
+ *
+ * @param initialPosition the initial marker position
  */
 @Composable
 public fun rememberMarkerState(
     key: String? = null,
-    position: LatLng = LatLng(0.0, 0.0)
+    initialPosition: LatLng = LatLng(0.0, 0.0)
 ): MarkerState = rememberSaveable(key = key, saver = MarkerState.Saver) {
-    MarkerState(position)
+    MarkerState(initialPosition)
 }
 
 /**