fix: IllegalArgumentException is clearer than ArrayIndexOutOfBounds #1241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
SseO-KR
changed the title
SseO-KR
changed the title
|
Gentle ping to @wangela , Hi! can you review this PR? I need to fix this. thanks! 🙇 |
kikoso
approved these changes
Dec 14, 2023
kikoso
requested changes
Dec 14, 2023
library/src/main/java/com/google/maps/android/data/kml/KmlFeatureParser.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Enrique López Mañas <[email protected]>
|
Thanks to review! I updated error message @kikoso ! |
kikoso
approved these changes
Dec 14, 2023
googlemaps-bot
pushed a commit
that referenced
this pull request
Dec 20, 2023
## [3.8.2](v3.8.1...v3.8.2) (2023-12-20) ### Bug Fixes * IllegalArgumentException is clearer than ArrayIndexOutOfBounds ([#1241](#1241)) ([9c882be](9c882be))
|
🎉 This PR is included in version 3.8.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
KMZ with empty coordinates throw ArrayIndexOutOfBounds.
Modification
throw new IllegalArgumentException("It is wrong coordinate, latitude and longitude should be set");when empty and wrong coordinates.Result
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
BREAKING CHANGEfooter so when this change is integrated a major version update is triggered. See: https://www.conventionalcommits.org/en/v1.0.0/Fixes #1228 🦕