Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added lint report #1406

Merged
merged 8 commits into from
Oct 28, 2024
Merged

chore: added lint report #1406

merged 8 commits into from
Oct 28, 2024

Conversation

kikoso
Copy link
Collaborator

@kikoso kikoso commented Oct 15, 2024

This PR uploads the SARIF Lint file to get the warnings reported.

@googlemaps-bot
Copy link
Contributor

googlemaps-bot commented Oct 15, 2024

Code Coverage

Overall Project 38.14% 🍏
File Coverage
KmlLayer.java 0% 🍏
DefaultClusterRenderer.java 0% 🍏
MarkerManager.java 0% 🍏

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@kikoso kikoso marked this pull request as ready for review October 16, 2024 08:32
@kikoso kikoso requested a review from a team as a code owner October 16, 2024 08:32
@kikoso kikoso requested a review from willum070 October 16, 2024 08:32
demo/src/main/res/layout/places_demo.xml Dismissed Show dismissed Hide dismissed
@dkhawk dkhawk merged commit 9cc6c66 into main Oct 28, 2024
9 checks passed
@dkhawk dkhawk deleted the chore/added_lint_report branch October 28, 2024 19:58
@@ -143,7 +146,7 @@ public boolean onClusterClick(Cluster<Person> cluster) {
try {
getMap().animateCamera(CameraUpdateFactory.newLatLngBounds(bounds, 100));
} catch (Exception e) {
e.printStackTrace();
Log.e("MapsDemo", Objects.requireNonNull(e.getMessage()));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: we should consider using requireNonNullElse here.

@googlemaps-bot
Copy link
Contributor

🎉 This PR is included in version 3.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@googlemaps-bot
Copy link
Contributor

🎉 This PR is included in version 3.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

2 similar comments
@googlemaps-bot
Copy link
Contributor

🎉 This PR is included in version 3.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@googlemaps-bot
Copy link
Contributor

🎉 This PR is included in version 3.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants