Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add support to obj-c and java formatting #240

Merged
merged 4 commits into from
Sep 12, 2024

Conversation

jokerttu
Copy link
Contributor

@jokerttu jokerttu commented Aug 30, 2024

Adds support for formatting and checking the formatting for Java and Objective-C files.
Formatting is checked as part of the CI and lefthook pre-commit hooks.
Added helper scripts

format:

./scripts/format-java.sh
./scripts/format-objc.sh

check:

./scripts/format-java.sh --check
./scripts/format-objc.sh --check

Uses google-java-format for Java files and clang-format -style=Google for Objective-C files.

  • Tests pass
  • Appropriate changes to documentation are included in the PR

@jokerttu
Copy link
Contributor Author

This PR is missing formatted files, and will fail on check-formatting tests.
After #239 is landed, I'll update this PR to include the formatted files.

Copy link
Contributor

@caio1985 caio1985 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jokerttu jokerttu force-pushed the chore/setup-formatting branch from 57e9528 to 08d2795 Compare September 3, 2024 06:24
@jokerttu jokerttu force-pushed the chore/setup-formatting branch from 08d2795 to 4b78125 Compare September 12, 2024 07:28
@jokerttu jokerttu marked this pull request as ready for review September 12, 2024 07:42
@jokerttu jokerttu merged commit 814e7de into googlemaps:main Sep 12, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants