Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: map view without navigation #259

Merged
merged 12 commits into from
Sep 13, 2024
Merged

feat: map view without navigation #259

merged 12 commits into from
Sep 13, 2024

Conversation

illuminati1911
Copy link
Contributor

@illuminati1911 illuminati1911 commented Sep 12, 2024 •
edited by jokerttu
Loading

Resolves #254
Resolves #104
Fixes #234

  • Separate MapView component has been implemented, allowing the classic map to be displayed without any effects from an ongoing or initialized navigation session.
  • If map without navigation is used
    • On Android a new fragment type SupportMapFragment is created instead of SupportNavigationFragment.
    • On iOS the same view will be used, but the navigation session will not be attached to the map
  • Fixed map zooming on iOS. Previously it always zoomed into/out of user's location.
  • Tests pass
  • Appropriate changes to documentation are included in the PR

jokerttu
jokerttu approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@jokerttu jokerttu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@illuminati1911 illuminati1911 force-pushed the feat/map-view-without-navigation branch from 4a23331 to 39c5db8 Compare September 13, 2024 04:41
@jokerttu jokerttu merged commit 15fd94b into googlemaps:main Sep 13, 2024
13 checks passed
@googlemaps-bot googlemaps-bot mentioned this pull request Sep 13, 2024
Merged
@jokerttu jokerttu deleted the feat/map-view-without-navigation branch October 15, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jokerttu jokerttu jokerttu approved these changes

@ArturoSalazarB16 ArturoSalazarB16 ArturoSalazarB16 approved these changes

Assignees

@caio1985 caio1985

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@illuminati1911 @jokerttu @ArturoSalazarB16 @caio1985