fix!: create bitmapdescriptor from asset on android #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArturoSalazarB16
approved these changes
Nov 19, 2024
jokerttu
force-pushed
the
fix/create-bitmapdescriptor-from-asset-on-android
branch
from
ade6831 to
c75fe1b
Compare
jokerttu
force-pushed
the
fix/create-bitmapdescriptor-from-asset-on-android
branch
from
c75fe1b to
c2c255f
Compare
jokerttu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On android BitmapDescriptorFactory.fromPath was used to load bitmap image for markers and groundoverlays, but this is ment to be used only with absolute paths to images. And iOS impelementation uses named assets as well, this PR changes android to use assets as well.
In future there most likely will be need for better control to support custom images, like from url, or given as bytearray. This PR will fix existing behaviour so that it can be used with custom asset images.
Example app is updated have exampe how to add custom asset images to the project.
Fixes #346
Fixes #154