fix: Ask user to confirm generated passphrase before invocing pinentry #3035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to avoid users not seeing their generated password if using e.g. pinentry curses UI. Fixes gopasspw#3030 Signed-off-by: Dominik Schulz <[email protected]>
AnomalRoil
reviewed
Jan 13, 2025
|
|
||
| // Prompt to confirm that the user noted their passphrase | ||
| if want, err := termio.AskForBool(ctx, "Did you save your passphrase?", true); err != nil || !want { | ||
| return fmt.Errorf("user did not confirm saving the passphrase: %w", err) |
There was a problem hiding this comment.
Note that not confirming here would still cause the identity file to have been written in step on Line 184, but not in a useable way: gopass will still consider itself not properly initialized, and next time you run the setup, you will be prompted for that old passphrase that was generated during the failed setup between the steps
$ gopass setup --crypto age
🌟 Welcome to gopass!
🌟 Initializing a new password store ...
<PROMPT FOR THAT PASSPHRASE>
🔐 No useable cryptographic keys. Generating new key pair
<...>
which is a somewhat weird edge case. I don't have a good solution, but maybe we should delete the identity file in case it failed to setup? That shouldn't cause issues for a fully initialized store since these won't even let user go through setup again.
There was a problem hiding this comment.
Sounds like a good idea. Let me add that to this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to avoid users not seeing their generated password if using e.g. pinentry curses UI.
Fixes #3030