Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mongo db integration #13

Closed
wants to merge 9 commits into from
Closed

Mongo db integration #13

wants to merge 9 commits into from

Conversation

gemoreno
Copy link
Contributor

  • Add Lombok dependecy for reducing code on class definitions
  • Add mongoDB to spring app
  • Created packages for models, controllers, repository and services.
  • Add Notification functionality.

nsalazar0429 and others added 3 commits April 2, 2024 19:33
@nsalazar0429
Merge pull request #8 from gopinathsjsu/development
28383e0 
Sprint 2 changes
@nsalazar0429
Merge pull request #9 from gopinathsjsu/development
bf24f53 
PROJECT update GH action names
@gemoreno
MongoDB integration
3aadc3e 
- Add Lombok dependecy for reducing code on class definitions
- Add mongoDB to spring app
- Created packages for models, controllers, repository and services.
- Add Notification functionality.
nsalazar0429
nsalazar0429 reviewed Apr 11, 2024
View reviewed changes
Copy link
Contributor

@nsalazar0429 nsalazar0429 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm the code seems fine. However, your branch history looks weird 🤔

back_end/src/main/java/org/example/cmpe202_final/Cmpe202FinalApplication.java Outdated
Comment on lines 14 to 15
import java.time.LocalDateTime;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need to import this here ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted

@gemoreno
Copy link
Contributor Author

gemoreno commented Apr 11, 2024 •
edited
Loading

Added tests for Notification, controller, service and repo. It is still failing.
instructions covered ratio went from 0.63 to 0.73

@nsalazar0429
Copy link
Contributor

This PR is lo longer relevant

@nsalazar0429 nsalazar0429 deleted the mongoDB-integration branch May 9, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsalazar0429 nsalazar0429 nsalazar0429 left review comments

@mateajinkya mateajinkya mateajinkya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gemoreno @nsalazar0429 @mateajinkya