-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GC 61 & 62 - Grade list, Update score, Update submission link #46
Conversation
Students are unable to create new submissions Steps:
steps.webm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other less important comments:
- Make submit button black to match the app theme.
- Add margin to grade list item
- Rename empty grades text from ‘’No grades to show” to “There are no submissions to review at this time”
Fixed! fix_grades.webm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure keyboard dismisses after pressing update score
...nd/app/src/main/java/com/example/studentportal/assignment/ui/fragment/AssignmentsFragment.kt
Outdated
Show resolved
Hide resolved
front_end/app/src/main/java/com/example/studentportal/common/di/AppModule.kt
Outdated
Show resolved
Hide resolved
front_end/app/src/main/java/com/example/studentportal/grades/ui/layout/GradeListLayout.kt
Outdated
Show resolved
Hide resolved
..._end/app/src/test/java/com/example/studentportal/assignment/ui/AssignmentListFragmentTest.kt
Outdated
Show resolved
Hide resolved
front_end/app/src/main/java/com/example/studentportal/grades/ui/viewmodel/EditGradeViewModel.kt
Outdated
Show resolved
Hide resolved
front_end/app/src/main/java/com/example/studentportal/grades/ui/fragment/EditGradeFragment.kt
Outdated
Show resolved
Hide resolved
front_end/app/src/main/java/com/example/studentportal/grades/ui/fragment/EditGradeFragment.kt
Outdated
Show resolved
Hide resolved
front_end/app/src/main/java/com/example/studentportal/grades/service/GradeService.kt
Outdated
Show resolved
Hide resolved
front_end/app/src/main/java/com/example/studentportal/grades/ui/viewmodel/EditGradeViewModel.kt
Outdated
Show resolved
Hide resolved
front_end/app/src/main/java/com/example/studentportal/grades/ui/viewmodel/EditGradeViewModel.kt
Outdated
Show resolved
Hide resolved
add front end files for grade list frontend is fetching grades from backend with hardcoded assignmentId. Add a nav buttom for loading the grades fragment directly (for testing and demo purposes, remove later).
Now studentId is given as an optional request parameter. If not given, all grades for assignment are returned. If given, only grade for specific student is returned.
- Now backend's endpoing has an required userId request parameter. This is used to the decide what is fetched depending on user type. - Front end makes a call to backend a provides logged user's id.
This was previously added for testing purposes
Faculty can update grade's score Students can update grade's submission link Add interceptor to log HTTP request made by app
a284c59
to
640689d
Compare
student_edit_grade.webm
facult_edit_grade.webm