Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GC 61 & 62 - Grade list, Update score, Update submission link #46

Merged
merged 51 commits into from
May 7, 2024

Conversation

gemoreno
Copy link
Contributor

@gemoreno gemoreno commented May 2, 2024

@nsalazar0429
Copy link
Contributor

Students are unable to create new submissions

Steps:

  1. Login with [email protected] as a student
  2. Go to course CMPE-202
  3. Go to Assignments
  4. Click on Final assignment
steps.webm

Copy link
Contributor

@nsalazar0429 nsalazar0429 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other less important comments:

  • Make submit button black to match the app theme.
  • Add margin to grade list item
  • Rename empty grades text from ‘’No grades to show” to “There are no submissions to review at this time”

@gemoreno
Copy link
Contributor Author

gemoreno commented May 4, 2024

Students are unable to create new submissions

Steps:

  1. Login with [email protected] as a student
  2. Go to course CMPE-202
  3. Go to Assignments
  4. Click on Final assignment

steps.webm

Fixed!

fix_grades.webm

Copy link
Contributor

@nsalazar0429 nsalazar0429 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure keyboard dismisses after pressing update score

gemoreno added 24 commits May 6, 2024 15:31
add front end files for grade list
frontend is fetching grades from backend with hardcoded assignmentId.
Add a nav buttom for loading the grades fragment directly (for testing and demo purposes, remove later).
Now studentId is given as an optional request parameter. If not given, all grades for assignment are returned. If given, only grade for specific student is returned.
- Now backend's endpoing has an required userId request parameter. This is used to the decide what is fetched depending on user type.
- Front end makes a call to backend a provides logged user's id.
This was previously added for testing purposes
@gemoreno gemoreno force-pushed the GC-62-Assign-grades branch from a284c59 to 640689d Compare May 6, 2024 22:57
@gemoreno gemoreno requested a review from nsalazar0429 May 7, 2024 04:27
@nsalazar0429 nsalazar0429 merged commit ae3ca11 into development May 7, 2024
2 checks passed
@nsalazar0429 nsalazar0429 deleted the GC-62-Assign-grades branch May 9, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants