GC-66 Implement announcements #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nsalazar0429
commented
May 8, 2024
•
nsalazar0429
commented
gemoreno
approved these changes
May 8, 2024
nsalazar0429
added a commit
that referenced
this pull request
May 9, 2024
* Fix for notifications * "Remove .idea\gradle.xml and misc.xml from repository" * Commit with dynamically loading username * Refactored code with added viewmodel tests * Updated commit with added gradle file * Fix formatting for ktlintCheck * Fix test case for NotificationServiceRepo * Update NotificationListUseCaseTest.kt * delete MockNotificationListDataSource.kt * Update NotificationsFragment.kt * Update NotificationListViewModelTest.kt * Dynamically displays other fields in the user profile page * Updated BE tests. * Fixed formatting issues with Kotlin. * Fixed another ktlint issue * Removed unnecessary imports * Fixed another ktlint issue...because ktlint is unnecessarily strict. * Fixed issues in ProfileFragment * Final checks complete * Removed ProfileFragmentTest.kt * Converted to using moshi instead of gson, fixed some more vulnerabilities * GC-56 implement course menu * GC-47 profile page * GC-47 profile page BE * GC-47 stopKoin * GC-47 Fix koin test * GC-47 format * GC-47 koin * GC-47 run tests parallel * GC-47 revert * GC-47 fix tests * GC-47 format * GC-47 fix * GC-47 format * mock statically GC-47 * GC-47 fix test * GC-47 update dependencies * GC-47 format * GC-47 ignore flaky test * ignore test * GC-47 Rollback * Format * ignore * GC-47 IGnore * GC-47 Ignore * GC-47 ignore * GC-65 assignments * GC-65 fix formatting * GC-65 fix tests * GC-65 ignore flaky test * GC-65 ignore flaky test * GC-65 ignore flaky test * GC-65 Flaky test * GC-65 Flaky test * GC-65 Flaky test * GC-65 Flaky test * GC-65 Flaky test * GC-55 Auth BE changes * GC-55 Implement Authentication FE * Fetching students from course ID * Go to profile page when clicking on a user in a course * GC-60 fixes * GC-60 open profile when clicking on line item * GC-60 fix formatting * GC-57 add/update course * GC-57 format * GC-57 increase test coverage * add grade with student repo * Add grade list (not finished) * Add grade list add front end files for grade list frontend is fetching grades from backend with hardcoded assignmentId. Add a nav buttom for loading the grades fragment directly (for testing and demo purposes, remove later). * Delete user_id.csv * delete appInsightsSettings.xml * Correctly format with ktlinFormat * Add tests for GradeList frontend * Update GradeListViewModelTest.kt * Update GradeListViewModelTest.kt * Update CustomGradeRepository.java * Rename StudentGradeDTO to GradeWithStudentName * Delete gradle.xml * Update GradesFragment.kt * Move GradeListLayout from Fragment to new file * Update .gitignore * Update GradeListViewModelTest.kt * Update GradeListUseCase.kt * run KtlinFormat * rename `gradeRepository` to `customGradeRepository` in `GradeService.java` * Modify endpoint for fetching grades Now studentId is given as an optional request parameter. If not given, all grades for assignment are returned. If given, only grade for specific student is returned. * Adapt backend and frontend for fetching grades - Now backend's endpoing has an required userId request parameter. This is used to the decide what is fetched depending on user type. - Front end makes a call to backend a provides logged user's id. * Integrate assignment list with grades list * Remove `grades` from main side navbar This was previously added for testing purposes * update tests for grades * run .gradlew klintFormat * Update GradeTests.java * Remove hardcoded userId from AssignmentsFragment.kt * Add functionaly to update Grades Faculty can update grade's score Students can update grade's submission link Add interceptor to log HTTP request made by app * UserType in `EditGradeViewModel` now its read from koin * Fix test cases * Add tests for grades backend * Add tests for Grades Frontend * Update EditGradeViewModelTest.kt * Create a `Grade` object for each `Student` when an `Assignment` is created * Change EditGrade button color to black * Add margin to grade list item * Update string res "grades_empty" * Update GradesFragmentTest.kt * Add test for AssignmentService * Pass userId via fragment argument * update padding GradeListLayout.kt * Update AssignmentListFragmentTest.kt * Service now knows of GradeUseCaseModel * Created EditGradeUseCase * ktlinFormat * Edits tests * Update CourseFragment.kt * Edit EditGradeLayout.kt * Update padding * Edit test cases * Add EditGradeViewModelTest * Code is very close to completion. Just need to add layout logic to add to syllabus. (#49) * Fixed some bugs and added new layout * GC-59 update course content * GC-59 More changes to for content * GC-59 Address build issues * GC-59 Fix format issues --------- Co-authored-by: Napoleon Salazar <[email protected]> * GC-66 Implement announcements (#52) * GC-66 Implement announcements * GC-66 Fix user profile issue * Add agile reports (#53) * Add agile reports * Add component diagrams * Update README.md --------- Co-authored-by: gemj98 <[email protected]> Co-authored-by: mateajinkya <[email protected]> Co-authored-by: vipvivek15 <[email protected]> Co-authored-by: gemj98 <[email protected]>
nsalazar0429
added a commit
that referenced
this pull request
May 9, 2024
* Fix for notifications * "Remove .idea\gradle.xml and misc.xml from repository" * Commit with dynamically loading username * Refactored code with added viewmodel tests * Updated commit with added gradle file * Fix formatting for ktlintCheck * Fix test case for NotificationServiceRepo * Update NotificationListUseCaseTest.kt * delete MockNotificationListDataSource.kt * Update NotificationsFragment.kt * Update NotificationListViewModelTest.kt * Dynamically displays other fields in the user profile page * Updated BE tests. * Fixed formatting issues with Kotlin. * Fixed another ktlint issue * Removed unnecessary imports * Fixed another ktlint issue...because ktlint is unnecessarily strict. * Fixed issues in ProfileFragment * Final checks complete * Removed ProfileFragmentTest.kt * Converted to using moshi instead of gson, fixed some more vulnerabilities * GC-56 implement course menu * GC-47 profile page * GC-47 profile page BE * GC-47 stopKoin * GC-47 Fix koin test * GC-47 format * GC-47 koin * GC-47 run tests parallel * GC-47 revert * GC-47 fix tests * GC-47 format * GC-47 fix * GC-47 format * mock statically GC-47 * GC-47 fix test * GC-47 update dependencies * GC-47 format * GC-47 ignore flaky test * ignore test * GC-47 Rollback * Format * ignore * GC-47 IGnore * GC-47 Ignore * GC-47 ignore * GC-65 assignments * GC-65 fix formatting * GC-65 fix tests * GC-65 ignore flaky test * GC-65 ignore flaky test * GC-65 ignore flaky test * GC-65 Flaky test * GC-65 Flaky test * GC-65 Flaky test * GC-65 Flaky test * GC-65 Flaky test * GC-55 Auth BE changes * GC-55 Implement Authentication FE * Fetching students from course ID * Go to profile page when clicking on a user in a course * GC-60 fixes * GC-60 open profile when clicking on line item * GC-60 fix formatting * GC-57 add/update course * GC-57 format * GC-57 increase test coverage * add grade with student repo * Add grade list (not finished) * Add grade list add front end files for grade list frontend is fetching grades from backend with hardcoded assignmentId. Add a nav buttom for loading the grades fragment directly (for testing and demo purposes, remove later). * Delete user_id.csv * delete appInsightsSettings.xml * Correctly format with ktlinFormat * Add tests for GradeList frontend * Update GradeListViewModelTest.kt * Update GradeListViewModelTest.kt * Update CustomGradeRepository.java * Rename StudentGradeDTO to GradeWithStudentName * Delete gradle.xml * Update GradesFragment.kt * Move GradeListLayout from Fragment to new file * Update .gitignore * Update GradeListViewModelTest.kt * Update GradeListUseCase.kt * run KtlinFormat * rename `gradeRepository` to `customGradeRepository` in `GradeService.java` * Modify endpoint for fetching grades Now studentId is given as an optional request parameter. If not given, all grades for assignment are returned. If given, only grade for specific student is returned. * Adapt backend and frontend for fetching grades - Now backend's endpoing has an required userId request parameter. This is used to the decide what is fetched depending on user type. - Front end makes a call to backend a provides logged user's id. * Integrate assignment list with grades list * Remove `grades` from main side navbar This was previously added for testing purposes * update tests for grades * run .gradlew klintFormat * Update GradeTests.java * Remove hardcoded userId from AssignmentsFragment.kt * Add functionaly to update Grades Faculty can update grade's score Students can update grade's submission link Add interceptor to log HTTP request made by app * UserType in `EditGradeViewModel` now its read from koin * Fix test cases * Add tests for grades backend * Add tests for Grades Frontend * Update EditGradeViewModelTest.kt * Create a `Grade` object for each `Student` when an `Assignment` is created * Change EditGrade button color to black * Add margin to grade list item * Update string res "grades_empty" * Update GradesFragmentTest.kt * Add test for AssignmentService * Pass userId via fragment argument * update padding GradeListLayout.kt * Update AssignmentListFragmentTest.kt * Service now knows of GradeUseCaseModel * Created EditGradeUseCase * ktlinFormat * Edits tests * Update CourseFragment.kt * Edit EditGradeLayout.kt * Update padding * Edit test cases * Add EditGradeViewModelTest * Code is very close to completion. Just need to add layout logic to add to syllabus. (#49) * Fixed some bugs and added new layout * GC-59 update course content * GC-59 More changes to for content * GC-59 Address build issues * GC-59 Fix format issues --------- Co-authored-by: Napoleon Salazar <[email protected]> * GC-66 Implement announcements (#52) * GC-66 Implement announcements * GC-66 Fix user profile issue * Add agile reports (#53) * Add agile reports * Add component diagrams * Update README.md * Update profile * Update README.md * Fix formatting --------- Co-authored-by: gemj98 <[email protected]> Co-authored-by: mateajinkya <[email protected]> Co-authored-by: vipvivek15 <[email protected]> Co-authored-by: gemj98 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.