Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hover & Completion UI rendering #1115

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Hover & Completion UI rendering #1115

merged 1 commit into from
Nov 29, 2024

Conversation

nighca
Copy link
Collaborator

@nighca nighca commented Nov 26, 2024

Update #1105, based on #1109.

  • UI rendering solution for Hover & Completion, based on Monaco "content widget"

  • Uniform structure for UI features of CodeEditor

    A UI feature foo typically consists of these concepts:

    • FooProvider: Provides external data or abilities, implemented and passed-in by CodeEditor or external application code
    • FooController: Manages state and logic for foo, integrates with FooProvider
    • FooUI.vue: Renders the foo UI based on the state in FooController

Copy link

qiniu-prow bot commented Nov 26, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@nighca nighca changed the title [WIP] Hover UI implementation Hover & Completion UI rendering Nov 27, 2024
@nighca nighca marked this pull request as ready for review November 27, 2024 10:50
@nighca nighca requested a review from Copilot November 27, 2024 10:50
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 17 changed files in this pull request and generated 1 suggestion.

Files not reviewed (12)
  • spx-gui/src/components/editor/code-editor/ui/completion.ts: Evaluated as low risk
  • spx-gui/src/components/editor/code-editor/ui/api-reference.ts: Evaluated as low risk
  • spx-gui/src/components/editor/code-editor/CodeEditor.vue: Evaluated as low risk
  • spx-gui/src/components/editor/code-editor/ui/MonacoEditor.vue: Evaluated as low risk
  • spx-gui/src/components/editor/code-editor/ui/completion/CompletionCard.vue: Evaluated as low risk
  • spx-gui/src/components/editor/code-editor/ui/api-reference/APIReferenceUI.vue: Evaluated as low risk
  • spx-gui/src/components/editor/code-editor/ui/hover/HoverUI.vue: Evaluated as low risk
  • spx-gui/src/components/editor/code-editor/ui/completion/CompletionUI.vue: Evaluated as low risk
  • spx-gui/src/components/editor/code-editor/ui/CodeEditorUI.vue: Evaluated as low risk
  • spx-gui/src/components/editor/code-editor/ui/hover/HoverCard.vue: Evaluated as low risk
  • spx-gui/src/components/editor/code-editor/ui/hover.ts: Evaluated as low risk
  • spx-gui/src/components/editor/code-editor/ui/completion/index.ts: Evaluated as low risk
Comments skipped due to low confidence (1)

spx-gui/src/components/editor/code-editor/ui/common.ts:36

  • The correctness of the fromMonacoTextModelUri function is uncertain. Please verify its correctness and update the comment accordingly.
// TODO: check if this is correct

@qiniu-ci
Copy link

This PR has been deployed to the preview environment. You can explore it using the preview URL.

Warning

Please note that deployments in the preview environment are temporary and will be automatically cleaned up after a certain period. Make sure to explore it before it is removed. For any questions, contact the Go+ Builder team.

@aofei aofei merged commit e8168e0 into goplus:dev Nov 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants