-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hover & Completion UI rendering #1115
Conversation
Skipping CI for Draft Pull Request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 17 changed files in this pull request and generated 1 suggestion.
Files not reviewed (12)
- spx-gui/src/components/editor/code-editor/ui/completion.ts: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/ui/api-reference.ts: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/CodeEditor.vue: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/ui/MonacoEditor.vue: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/ui/completion/CompletionCard.vue: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/ui/api-reference/APIReferenceUI.vue: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/ui/hover/HoverUI.vue: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/ui/completion/CompletionUI.vue: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/ui/CodeEditorUI.vue: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/ui/hover/HoverCard.vue: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/ui/hover.ts: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/ui/completion/index.ts: Evaluated as low risk
Comments skipped due to low confidence (1)
spx-gui/src/components/editor/code-editor/ui/common.ts:36
- The correctness of the
fromMonacoTextModelUri
function is uncertain. Please verify its correctness and update the comment accordingly.
// TODO: check if this is correct
This PR has been deployed to the preview environment. You can explore it using the preview URL. Warning Please note that deployments in the preview environment are temporary and will be automatically cleaned up after a certain period. Make sure to explore it before it is removed. For any questions, contact the Go+ Builder team. |
Update #1105, based on #1109.
UI rendering solution for Hover & Completion, based on Monaco "content widget"
Uniform structure for UI features of
CodeEditor
A UI feature
foo
typically consists of these concepts:FooProvider
: Provides external data or abilities, implemented and passed-in byCodeEditor
or external application codeFooController
: Manages state and logic forfoo
, integrates withFooProvider
FooUI.vue
: Renders thefoo
UI based on the state inFooController