gox => gogen #241
gox => gogen #241
Conversation
![qiniu-x[bot]](https://avatars.githubusercontent.com/in/752628?s=60&v=4){kind=small}
| @@ -131,7 +131,7 @@ func testWith(t *testing.T, name string, fn string, code string, outFunc string, | |||
| } | |||
| pkg, err := NewPackage("", "main", doc, conf) | |||
| check(err) | |||
| file := gox.ASTFile(pkg.Package) | |||
| file := gogen.ASTFile(pkg.Package) | |||
There was a problem hiding this comment.
[golangci-lint] SA1019: gogen.ASTFile is deprecated: Use pkg.ASTFile instead. (staticcheck)
If you have any questions about this comment, feel free to raise an issue here:
| @@ -67,7 +67,7 @@ func (p Package) InitDependencies() { | |||
| switch t := scope.Lookup(uf).Type().(type) { | |||
| case *types.Signature: | |||
| sig = t | |||
| case *gox.SubstType: | |||
| case *gogen.SubstType: | |||
There was a problem hiding this comment.
[golangci-lint] SA1019: gogen.SubstType is deprecated: use TySubst instead of SubstType. (staticcheck)
If you have any questions about this comment, feel free to raise an issue here:
| if old != nil { | ||
| if t, ok := old.Type().(*gox.SubstType); ok { | ||
| if t, ok := old.Type().(*gogen.SubstType); ok { |
There was a problem hiding this comment.
[golangci-lint] SA1019: gogen.SubstType is deprecated: use TySubst instead of SubstType. (staticcheck)
If you have any questions about this comment, feel free to raise an issue here:
| @@ -57,7 +57,7 @@ func NewPointer(typ types.Type) types.Type { | |||
| return types.Typ[types.UnsafePointer] | |||
| } | |||
| case *types.Signature: | |||
| if gox.IsCSignature(t) { | |||
| if gogen.IsCSignature(t) { | |||
| return types.NewSignature(nil, t.Params(), t.Results(), t.Variadic()) | |||
There was a problem hiding this comment.
[golangci-lint] SA1019: types.NewSignature has been deprecated since Go 1.18: Use NewSignatureType instead which allows for type parameters. (staticcheck)
If you have any questions about this comment, feel free to raise an issue here:
| @@ -243,7 +243,7 @@ func execProjDone(base string, flags int, conf *c2goConf) { | |||
| if pkg := conf.Reused.Pkg(); pkg.IsValid() { | |||
| dir := pathutil.Canonical(base, conf.Target.Dir) | |||
| os.MkdirAll(dir, 0777) | |||
There was a problem hiding this comment.
[golangci-lint] Error return value of os.MkdirAll is not checked (errcheck)
If you have any questions about this comment, feel free to raise an issue here:
| @@ -131,7 +131,7 @@ func testWith(t *testing.T, name string, fn string, code string, outFunc string, | |||
| } | |||
| pkg, err := NewPackage("", "main", doc, conf) | |||
| check(err) | |||
| file := gox.ASTFile(pkg.Package) | |||
| file := gogen.ASTFile(pkg.Package) | |||
There was a problem hiding this comment.
[staticcheck] gogen.ASTFile is deprecated: Use pkg.ASTFile instead. (SA1019)
If you have any questions about this comment, feel free to raise an issue here:
| @@ -67,7 +67,7 @@ func (p Package) InitDependencies() { | |||
| switch t := scope.Lookup(uf).Type().(type) { | |||
| case *types.Signature: | |||
| sig = t | |||
| case *gox.SubstType: | |||
| case *gogen.SubstType: | |||
There was a problem hiding this comment.
[staticcheck] gogen.SubstType is deprecated: use TySubst instead of SubstType. (SA1019)
If you have any questions about this comment, feel free to raise an issue here:
| if old != nil { | ||
| if t, ok := old.Type().(*gox.SubstType); ok { | ||
| if t, ok := old.Type().(*gogen.SubstType); ok { |
There was a problem hiding this comment.
[staticcheck] gogen.SubstType is deprecated: use TySubst instead of SubstType. (SA1019)
If you have any questions about this comment, feel free to raise an issue here:
| @@ -57,7 +57,7 @@ func NewPointer(typ types.Type) types.Type { | |||
| return types.Typ[types.UnsafePointer] | |||
| } | |||
| case *types.Signature: | |||
| if gox.IsCSignature(t) { | |||
| if gogen.IsCSignature(t) { | |||
| return types.NewSignature(nil, t.Params(), t.Results(), t.Variadic()) | |||
There was a problem hiding this comment.
[staticcheck] types.NewSignature has been deprecated since Go 1.18: Use NewSignatureType instead which allows for type parameters. (SA1019)
If you have any questions about this comment, feel free to raise an issue here:
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #241 +/- ##
=======================================
Coverage 89.13% 89.13%
=======================================
Files 10 10
Lines 3517 3517
=======================================
Hits 3135 3135
Misses 299 299
Partials 83 83 ☔ View full report in Codecov by Sentry. |
No description provided.