fix: support multi level directory search mod #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xushiwei PTAL |
xushiwei
reviewed
Feb 21, 2024
| @@ -2296,9 +2315,7 @@ func (bi *BinaryInfo) loadDebugInfoMaps(image *Image, debugInfoBytes, debugLineB | |||
|
|
|||
| if cu.lineInfo != nil { | |||
| if imageMod == nil { | |||
| if mod, err := gopmod.Load(filepath.Dir(image.Path)); err == nil { | |||
There was a problem hiding this comment.
gopmod.Load already supports to lookup go.mod. does it have bug?
There was a problem hiding this comment.
work tree:
|cmd
|--gopcomm
|go.mod
command:
cmd/gopcomm: gopdlv debug main.gop
It will not find the go.mod file in the current directory
xushiwei
reviewed
Mar 12, 2024
| if mod, err := gopmod.Load(filepath.Dir(image.Path)); err == nil { | ||
| imageMod = mod | ||
| } | ||
| imageMod = getImageMod(image.Path) |
There was a problem hiding this comment.
gopmod.Load use https://pkg.go.dev/github.com/goplus/mod#FindGoMod to lookup go.mod. has it bugs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug: unable to find the go+project source file for breakpoint, the source file path is relative
The solution to the problem of not being able to locate the go.mod file in multi-level directories has been solved by searching for the go.mod file level by level upwards