Fix COHN cert default value, useful for multiple camera #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you rebase off of main? |
|
Ultimately we need a database to store the certificates (and any other information) per serial number. But this is a fine workaround for now. |
tcamise-gpsw
requested changes
Jan 7, 2025
| @@ -70,6 +70,7 @@ def parse_arguments() -> argparse.Namespace: | |||
| parser.add_argument("ssid", type=str, help="WiFi SSID to connect to.") | |||
| parser.add_argument("password", type=str, help="Password of WiFi SSID.") | |||
| parser.add_argument("url", type=str, help="RTMP server URL to stream to.") | |||
| parser.add_argument("identifier", type=str, help="GoPro identifier.") | |||
There was a problem hiding this comment.
This parameter already exists. It is added via the add_cli_args_and_parse below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.
I encounter an issue when attempting to connect multiple GoPros using COHN mode. Each connection to COHN mode consistently utilizes the same certificate name, resulting in the overwriting of the previously created cohn.crt file. To address this, I propose implementing a small fix that generates a certificate name based on the serial number of the GoPro camera. This modification will facilitate easier connectivity of multiple GoPro cameras in COHN mode.
🤙 Thank you!