Change structs back to classes #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code was ported from Java and some functions still have Java-styled functions that modify one or more class properties without having ’out’ or ‘ref’ keywords on parameter list, breaking the logic when classes are defined as value type instead of reference type as in java. I changed these classes back to class from struct fixing those issues and making sure that engine works as expected. That makes particle simulation work as expected but that is not 100% correct way to do this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code was ported from Java and some parts still have
Java-styled functions that modify one or more class properties without
having ’out’ or ‘ref’ keywords on parameter list, breaking the logic
when classes are defined as value type instead of reference type as in
java. I changed these classes back to class from struct fixing those
issues and making sure that engine works as expected. That makes
particle simulation work as expected but that is not 100% correct way
to do this.