Update server.go

[samyuktha-asokan]

After the connection is upgraded from the HTTP protocol to the WebSocket protocol, the network connection cannot be used for HTTP. The net/http server panics when the application attempts to write an HTTP response to a hijacked connection. You should not use netConn to write the response headers. Instead, you should use the http.ResponseWriter to write the response headers to avoid the log "http: response.WriteHeader on hijacked connection from...."

What type of PR is this? (check all applicable)

• Refactor
• Feature
• Bug Fix
• Optimization
• Documentation Update
• Go Version Update
• Dependency Update

Description

Related Tickets & Documents

• Related Issue #
• Closes #

Added/updated tests?

• Yes
• No, and this is why: please replace this line with details on why tests
  have not been included
• I need help with writing tests

Run verifications and test

• make verify is passing
• make test is passing

[ghost]

This PR attempts to write the websocket handshake response headers to the connection using ResponseWriter.Write method. This fails for two reasons:

• ResponseWriter.Write fails on a hijacked connection.
• Even if ResponseWriter.Write did not fail on the hijacked connection, ResponseWriter.Write writes the data to the response body, not the response header.

Many tests will fail with this change.

After the connection is upgraded from the HTTP protocol to the WebSocket protocol, the network connection cannot be used for HTTP

This is not true. The hijacker takes control of the connection and can implement whatever protocol it want, including HTTP.

[ghost]

@jaitaiwan This should be closed. Tests fail with the change. See previous comment.

[AlexVulaj]

I've closed this PR as per the comment above.