fix: always override default proxies

Gin trusts all proxies by default. This is a security problem.
gotify · Feb 4, 2024 · 949e5df · 949e5df
1 parent c68b2b5
commit 949e5df
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/router/router.go b/router/router.go
@@ -27,10 +27,8 @@ import (
 func Create(db *database.GormDatabase, vInfo *model.VersionInfo, conf *config.Configuration) (*gin.Engine, func()) {
 	g := gin.New()
 
-	if conf.Server.TrustedProxies != nil {
-		g.SetTrustedProxies(conf.Server.TrustedProxies)
-		g.ForwardedByClientIP = true
-	}
+	g.SetTrustedProxies(conf.Server.TrustedProxies)
+	g.ForwardedByClientIP = true
 
 	g.Use(func(ctx *gin.Context) {
 		// Map sockets "@" to 127.0.0.1, because gin-gonic can only trust IPs.