Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GOVCMSD8-363] Tweaks to nginx helpers #44

Merged
merged 2 commits into from
May 14, 2019
Merged

[GOVCMSD8-363] Tweaks to nginx helpers #44

merged 2 commits into from
May 14, 2019

Conversation

Feng-Shui
Copy link
Contributor

PR for #43

@tobybellwood tobybellwood changed the title Tweaks to nginx helpers [GOVCMSD8-363] Tweaks to nginx helpers May 13, 2019
@fubarhouse fubarhouse self-assigned this May 13, 2019
Copy link
Contributor

@fubarhouse fubarhouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Feng-Shui,

Things are checking out and the acceptance criteria for this change is successful.

These entries have been added to govcms8lagoon/nginx-drupal:latest:
FILE                                                                                                                                              SIZE
/usr/local/openresty/nginx/conf/helpers/200-blocks.conf                                                                                           647B
/usr/local/openresty/nginx/conf/helpers/210-expires.conf                                                                                          457B
/usr/local/openresty/nginx/conf/helpers/220-hotlink.conf                                                                                          213B

These entries have been deleted from govcms8lagoon/nginx-drupal:latest:
FILE                                                                                                                                              SIZE
/usr/local/openresty/nginx/conf/helpers/blocks.conf                                                                                               647B
/usr/local/openresty/nginx/conf/helpers/expires.conf                                                                                              318B
/usr/local/openresty/nginx/conf/helpers/hotlink.conf                                                                                              213B
  • Building
  • Testing
  • Expected changes are present
  • Diffs show no problems

Thanks for contributing!

@fubarhouse fubarhouse removed their assignment May 13, 2019
@Feng-Shui
Copy link
Contributor Author

Awesome, thanks Karl!

@tobybellwood tobybellwood merged commit 5af6601 into govCMS:master May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants