-
Notifications
You must be signed in to change notification settings - Fork 2
Updated scaffold-tooling to 2.0.1 release. #21
base: develop
Are you sure you want to change the base?
Conversation
Retain support for scaffold-tooling 1.x release.
@@ -10,7 +10,7 @@ | |||
], | |||
"require": { | |||
"govcms/govcms": "1.3.0", | |||
"govcms/scaffold-tooling": "2.0.0", | |||
"govcms/scaffold-tooling": "1.1.0|2.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only really relevant line in this PR - we need to support both the 1.1.0 and 2.0.1 release.
2.0.1 adds Solr 7.x support, which not all PaaS codebases are ready for.
} | ||
} | ||
}, | ||
"metadata-url": "/p2/%package%.json" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previous Satis update PRs have excluded metadata-url
and the accompanying .json
files.. is this intentional? It's the reason why this PR is so.. hefty.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To date the PRs simply contain the output generated by the satis app. I've just googled metadata-url
but I'm not wiser about the purpose of it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this is just the output from ahoy build stable
, looks like this is intentional for composer 2.0 support: https://github.com/composer/satis/blob/master/src/Builder/PackagesBuilder.php
When i run up the server I can see satis is offering 2.0.1 and 1.1.0, but |
Verified locally, looks good to me. I had a zombie php server from ctrl-C a running script. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I will draft release notes for CAB approval.
Retain support for scaffold-tooling 1.x release.