Skip to content
This repository has been archived by the owner on Nov 20, 2024. It is now read-only.

Updated scaffold-tooling to 2.0.1 release. #21

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

stooit
Copy link
Contributor

@stooit stooit commented May 19, 2020

Retain support for scaffold-tooling 1.x release.

Retain support for scaffold-tooling 1.x release.
@@ -10,7 +10,7 @@
],
"require": {
"govcms/govcms": "1.3.0",
"govcms/scaffold-tooling": "2.0.0",
"govcms/scaffold-tooling": "1.1.0|2.0.1",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only really relevant line in this PR - we need to support both the 1.1.0 and 2.0.1 release.

2.0.1 adds Solr 7.x support, which not all PaaS codebases are ready for.

}
}
},
"metadata-url": "/p2/%package%.json"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous Satis update PRs have excluded metadata-url and the accompanying .json files.. is this intentional? It's the reason why this PR is so.. hefty.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To date the PRs simply contain the output generated by the satis app. I've just googled metadata-url but I'm not wiser about the purpose of it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is just the output from ahoy build stable, looks like this is intentional for composer 2.0 support: https://github.com/composer/satis/blob/master/src/Builder/PackagesBuilder.php

@stooit stooit added the Needs review Pull requests needs a review from assigned developers label May 19, 2020
@simesy
Copy link
Contributor

simesy commented May 19, 2020

When i run up the server I can see satis is offering 2.0.1 and 1.1.0, but ahoy verify stable is failing. I'll have a look at why.

@simesy
Copy link
Contributor

simesy commented May 19, 2020

Verified locally, looks good to me. I had a zombie php server from ctrl-C a running script.

@pandaskii pandaskii added this to the 1.2.0 milestone May 20, 2020
@pandaskii pandaskii removed the Needs review Pull requests needs a review from assigned developers label May 20, 2020
Copy link

@pandaskii pandaskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I will draft release notes for CAB approval.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants