Removed deployment job, refactored tests and updated CI image. #23
Conversation
AlexSkrypnyk
commented
Jun 11, 2020
•
AlexSkrypnyk
commented
- Updated Docker image to use CI image hosted on GitHub.
- Removed deploy job as deployment is manual. The current configuration was confusing. The deployment should only be manual to respect git-flow.
- Refactored tests into a separate file to allow running locally.
- Split CI into 3 jobs to speed-up tests (~10 mins to ~2mins)
- Updated documentation formatting:
- Added more inline code blocks
- Fixed line length to fit into 80 characters
AlexSkrypnyk
force-pushed
the
feature/remove-deploy
branch
from
878ef0f to
9aad536
Compare
AlexSkrypnyk
changed the title
|
|
||
| # shellcheck disable=SC2002,SC2015 | ||
|
|
||
| # Satis application directory. |
There was a problem hiding this comment.
as usual, the first section is expected variables
|
|
||
| #------------------------------------------------------------------------------- | ||
|
|
||
| echo "--> Starting Satis web server on http://localhost:4141." |
There was a problem hiding this comment.
this part allows to kill previously started inbuilt php server from the previous run, start the server, wait for app to be ready and assess that the server was successfully started
| echo "--> Add http://localhost:4141/${SATIS_BRANCH} as a repository." | ||
| composer --working-dir="${GOVCMS_SCAFFOLD_DIR}" config repositories.govcms composer http://localhost:4141/"${SATIS_BRANCH}" | ||
|
|
||
| if [ "${SATIS_BRANCH}" = "master" ] || [ "${SATIS_BRANCH}" = "develop" ] ; then |
There was a problem hiding this comment.
the logic below has not been changed. only verbose output added
| @@ -1,140 +1,28 @@ | |||
| version: 2.1 | |||
| parameters: | |||
There was a problem hiding this comment.
cleaned up CI as we are only generating content manually. once there is a better automated process - the config can be revert. otherwise - this is a dead code.
| - develop | ||
| requires: | ||
| - test | ||
| - test |
There was a problem hiding this comment.
3 parallel jobs allows to reduce build time to ~2 mins and make sure that there are no artifacts from the previous build (clean run)
|
|
||
| Currently, updating is manual. The job to automate it was completed but it got stuck waiting | ||
| for deployment tokens. In the meantime it has been found that manual intervention is usually needed. | ||
| Updating of the Satis repository content is a manual process that includes |
There was a problem hiding this comment.
this is the only paragraph that was changed to explain what the process is.
The rest of the changes are formatting only.
|
Sweet, I was hesitant to remove all the automation without knowing the roadmap. This will be a clean change and it can serve as a reference if automation is ever re-added. |
