This repository has been archived by the owner on Aug 26, 2021. It is now read-only.
Update bug report template, add main nav documentation, fix discussion link, change page alert titles #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # content/_data.yml # content/components/_all.yml # content/components/side-nav/default.md # package-lock.json # src/assets/css/example.css.map # src/assets/css/style.css.map
Update the bug report issue template
Main navigation documentation
Fix discussion link
alex-page
changed the title
Update the page-alert examples titles to their correct names
alex-page
changed the title
Xochi
approved these changes
Sep 4, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #138 and govau/design-system-components#412
The main navigation documentation required quite a few changes to structure of components and demos.
I had to tweak the way examples work as the main navigation needed a fixed height and not a flexible one. Having a flexible height meant that opening the menu made the page janky and gross UX.
I also implemented the main navigation as the main nav on the docs site. The current implementation had a lot of menus combined which meant it had to be decoupled. I think we should clean this up and I have created a seperate ticket #205
I have browser and device tested this, back to IE8