Accessibility & VoiceOver support #103
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added filprivate property accessibilityChartElements which is used to adhere to the UIAccessibilityContainer protocol methods. Rather than render data twice, the methods used attempt to make UIAccessibilityElements as they are drawn using existing functions in SwiftChart.
|
I hope this will be merged, now I have the same task and will use this branch, thank you @mathewa6 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! Thanks for the library.
I noticed that currently, SwiftCharts isn't accessible to VoiceOver and other clients that use UIAccessibility. You can test this by turning on VoiceOver and running the example project, where it currently defaults to reading the X and Y axes labels.
This PR attempts to address this issue, by making the data contained in each chart accessible, using the UIAccessibilityContainer protocol. I've attempted to minimize changes to rendering and structure and have left comments describing additions. Changes are apparent when using the example project with VoiceOver running, otherwise there should be no visible changes. I've added 2 additional public properties:
accessibilityXLabelsandaccessibilityYLabels. These allow the customization of labels to sound better to an audio interface. I've updated the StockChartsViewController to make use of both of them to demonstrate its effect.Happy to make any changes!