-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prep 5.0.0-M1 #67
Open
matrei
wants to merge
19
commits into
5.0.x
Choose a base branch
from
prep-5.0.0-M1
base: 5.0.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Prep 5.0.0-M1 #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Upgrade from `2.1.0` to `2.1.2`. - [2.1.2 Release Notes](https://github.com/greenmail-mail-test/greenmail/releases/tag/release-2.1.2). - [2.1.1 Release Notes](https://github.com/greenmail-mail-test/greenmail/releases/tag/release-2.1.1).
- Upgrade from `4.0.2` to `4.0.4` - [4.0.4 Release Notes](https://github.com/asciidoctor/asciidoctor-gradle-plugin/releases/tag/release_4_0_4) - [4.0.3 Release Notes](https://github.com/asciidoctor/asciidoctor-gradle-plugin/releases/tag/release_4_0_3)
- Move `repo.grails.org` to the top
- Rename `publishing.gradle` to `publish-config.gradle` file to be in-line with the other include files.
- New compatibility version: Grails 7. - Update with new repo and organization home.
- Update with new GitHub organization home.
- Consensus in Grails team is to remove `buildSrc` (where possible) and version catalogs for simplicity and consistency across repositories.
- `grails-publish` Gradle Plugin is a new way to simplify publishing in Grails 7.
- Prevents the runner from being a moving target by using a fixed version.
- Aligns with the typical property order for actions/setup-java for consistency.
- Dependencies are now arranged in scope order for better readability and consistency.
- `grails-plugin` is now handling disabling Boot tasks - Refactor `java-config.gradle` and `grails-plugin-config.gradle` into the main build file as these are so small it is not worth having them extracted in a single-project build. - Extract java version to `gradle.properties` and use `compileJava.options.release` instead of `java.sourceCompatibility`. - Extract version of `asciidoctor` gradle plugin to `gradle.properties`. - Align Gradle plugin inclusion to use apply, as Grails plugins must use that.
- Removed `isReleaseVersion` and `isSnapshot` properties, which are no longer needed after migrating to `grailsPublish`.
sbglasius
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Still releasing to org.grails.plugins
group?
@sbglasius Is this not correct? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR preps the project for a 5.0.0-M1 release. Please refer to the individual commit messages for detailed descriptions of the changes.