Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep 5.0.0-M1 #67

Open
wants to merge 19 commits into
base: 5.0.x
Choose a base branch
from
Open

Prep 5.0.0-M1 #67

wants to merge 19 commits into from

Conversation

matrei
Copy link
Contributor

@matrei matrei commented Jan 22, 2025

This PR preps the project for a 5.0.0-M1 release. Please refer to the individual commit messages for detailed descriptions of the changes.

matrei added 19 commits January 22, 2025 14:22
- Move `repo.grails.org` to the top
- Rename `publishing.gradle` to `publish-config.gradle` file to be in-line with the other include files.
- New compatibility version: Grails 7.
- Update with new repo and organization home.
- Update with new GitHub organization home.
- Consensus in Grails team is to remove `buildSrc` (where possible) and version catalogs for simplicity and consistency across repositories.
- `grails-publish` Gradle Plugin is a new way to simplify publishing in Grails 7.
- Prevents the runner from being a moving target by using a fixed version.
- Aligns with the typical property order for actions/setup-java for consistency.
- Dependencies are now arranged in scope order for better readability and consistency.
- `grails-plugin` is now handling disabling Boot tasks
- Refactor `java-config.gradle` and `grails-plugin-config.gradle` into the main build file as these are so small it is not worth having them extracted in a single-project build.
- Extract java version to `gradle.properties` and use `compileJava.options.release` instead of `java.sourceCompatibility`.
- Extract version of `asciidoctor` gradle plugin to `gradle.properties`.
- Align Gradle plugin inclusion to use apply, as Grails plugins must use that.
- Removed `isReleaseVersion` and `isSnapshot` properties, which are no longer needed after migrating to `grailsPublish`.
@matrei matrei requested a review from sbglasius January 22, 2025 16:45
Copy link
Member

@sbglasius sbglasius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Still releasing to org.grails.plugins group?

@matrei
Copy link
Contributor Author

matrei commented Jan 23, 2025

Looks good to me. Still releasing to org.grails.plugins group?

@sbglasius Is this not correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants