Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation tests on the index range of getBindGroupLayout() #4182

Merged
merged 1 commit into from
Feb 8, 2025

Conversation

Jiawei-Shao
Copy link
Collaborator

This patch allows using an index less than the maximum number of bind groups as a parameter of getBindGroupLayout() to follow the latest WebGPU SPEC.

Issue: #4075


Requirements for PR author:

  • [*] All missing test coverage is tracked with "TODO" or .unimplemented().
  • [*] New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • [*] Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • [*] Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

This patch allows using an index less than the maximum number of
bind groups as a parameter of `getBindGroupLayout()` to follow the
latest WebGPU SPEC.
@Jiawei-Shao Jiawei-Shao requested a review from Kangz February 7, 2025 02:36
@Jiawei-Shao Jiawei-Shao merged commit 3539008 into gpuweb:main Feb 8, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants