Add TypeScript template #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juancarlosfarah
requested changes
Oct 12, 2022
juancarlosfarah
requested changes
Oct 14, 2022
juancarlosfarah
requested changes
Oct 17, 2022
spaenleh
requested review from
juancarlosfarah
and removed request for
codeofmochi
juancarlosfarah
requested changes
Oct 20, 2022
src/initStarter.js
Outdated
| } | ||
| } | ||
| }; | ||
|
|
||
| const writeChangeLog = async (rootPath) => { |
There was a problem hiding this comment.
I actually think we no longer need to write the CHANGELOG file. This used to be because standard-version did not write the first version of the file, but now I think they do. Can you confirm / remove, please?
There was a problem hiding this comment.
Yes, there is no need to create the changelog file anymore. It is done automatically when doing the first release.
As a side note, the package standard-version is marked as deprecated since this summer (lack of maintainers i think).
But for the moment it is fine i think. And there is a fork that proposes itself as a successor, see this issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the typescript template to the cli and adapts it to the new Graasp.
We will release a new version (0.5.0) or maybe a major bump.
closes #61