Fix stat on Windows FAT file systems #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`GetFileInformationByHandleEx` returns ERROR_INVALID_PARAMETER on FAT file systems, so this breaks stat. See also https://go-review.googlesource.com/c/go/+/154377/.
modmuss50
approved these changes
Jul 17, 2021
for performance reasons when stating non-symlinks. See #203
So we don't need the error handling on FAT for the illegal argument.
|
I ran the jmh benchmarks in the Gradle project on Windows for these changes: After: So this fixes #203 as well. |
mlopatkin
requested changes
Jul 19, 2021
since CloseHandle may create its own error.
mlopatkin
approved these changes
Jul 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetFileInformationByHandleExreturns ERROR_INVALID_PARAMETERon FAT file systems, so this breaks stat.
See also https://go-review.googlesource.com/c/go/+/154377/.