Skip to content

Commit

Permalink
add call to set perf query (#6065)
Browse files Browse the repository at this point in the history
  • Loading branch information
mattdurham authored Jan 8, 2024
1 parent f471706 commit b7c1089
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 0 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ Main (unreleased)
- [GO-2023-2412](https://github.com/advisories/GHSA-7ww5-4wqc-m92c)
- [CVE-2023-49568](https://github.com/advisories/GHSA-mw99-9chc-xw7r)

### Bugfixes

- Fix performance issue where perf lib where clause was not being set, leading to timeouts in collecting metrics for windows_exporter. (@mattdurham)

v0.39.0-rc.0 (2024-01-05)
-------------------------

Expand Down
5 changes: 5 additions & 0 deletions pkg/integrations/windows_exporter/windows_exporter_windows.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,11 @@ func New(logger log.Logger, c *Config) (integrations.Integration, error) {
if err != nil {
return nil, err
}
err = winCol.SetPerfCounterQuery()
if err != nil {
return nil, err
}

return integrations.NewCollectorIntegration(c.Name(), integrations.WithCollectors(
// Hard-coded 4m timeout to represent the time a series goes stale.
// TODO: Make configurable if useful.
Expand Down

0 comments on commit b7c1089

Please sign in to comment.