Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit of estimator component #3258

Closed
wants to merge 11 commits into from
Closed

Conversation

rgeyer
Copy link
Contributor

@rgeyer rgeyer commented Mar 13, 2023

PR Description

Adds a new component for estimating/reporting the "amount" of a given billable unit is being received.

For metrics, the number of active series.
For logs and traces, the byte throughput/counter.

The component will also expose a prometheus exporter interface, and a list of targets which can be scraped and remote written for analysis.

Notes to the Reviewer

PR Checklist

  • CHANGELOG updated
  • Documentation added
  • Tests updated

@rgeyer rgeyer marked this pull request as draft March 13, 2023 22:07
Actually export receiver
}

type Exports struct {
metricsReceiver *prometheus.Interceptor `river:metrics_reciever,attr`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
metricsReceiver *prometheus.Interceptor `river:metrics_reciever,attr`
metricsReceiver *prometheus.Interceptor `river:metrics_receiver,attr`

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling is hard 😂

This is getting refactored anyhow, but, I have fixed the spelling :)

@tpaschalis
Copy link
Member

Hey there @rgeyer 👋

Do you think we should make a push for including these new components (adding documentations, tidying code up etc), or was it more of a proof of concept?

I'm going through a round of tidying up our PR queue and was thinking of closing this otherwise.

@rgeyer
Copy link
Contributor Author

rgeyer commented Dec 12, 2023

Hey there @rgeyer 👋

Do you think we should make a push for including these new components (adding documentations, tidying code up etc), or was it more of a proof of concept?

I'm going through a round of tidying up our PR queue and was thinking of closing this otherwise.

Only the metrics portion was "correct". The logging functionality is incorrect, and I'm not sure I'd be able to resolve it.

That said, the work that @captncraig did for the most recent hackathon (x-ray), I think this becomes superflous. Also, x-ray seems more complete and useful.

I think we can close this.

@rgeyer rgeyer closed this Dec 12, 2023
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants