Update version of windows_exporter

[MarkDordoy]

PR Description

This PR updates the windows_exporter dependency to master (commit hash f8c298e038f8e0fcaf7f77fd591a5e1dfeb7f27b). Full change log here

Notes to the Reviewer

• windows_ad_ldap_client_sessions added to ad collector. (@MarkDordoy)
• windows_hyperv_host_cpu_wait_time_per_dispatch_total and windows_hyperv_vm_cpu_wait_time_per_dispatch_total added to hyperv collector. (@yuriyostapenko)
• nps collector created. (@rebortg)
• adfs collector metric docs updated to correctly reflect metric names. (@breed808)

PR Checklist

• CHANGELOG.md updated

[CLAassistant]

All committers have signed the CLA.

[MarkDordoy]

I think this is ready for review. My first time contributing so please let me know if anything is missing/required and I'll get this updated.

[tpaschalis]

Apologies, this is a bit misleading. If you look a bit further down, you'll see a replace statement for this package.

We're actually using a fork of the Windows exporter over at https://github.com/grafana/windows_exporter to allow some config options to be propagated correctly.

It is a bit more toil, but for this exporter specifically we'd have to rebase our fork to a later tag of the upstream exporter, keep our required commits on top and update the replace statement to that SHA. cc @mattdurham

[MarkDordoy]

ahh yes, I see now.

What would be the process to get this forked repo synced with master of the originating repo?

[mattdurham]

Its on my todo, I have a PR to but it got stale. prometheus-community/windows_exporter#1227

will see if i can find some time to resolve

[MarkDordoy]

for my future reference @mattdurham , if I want to make changes/extend the windows_exporter, should I update the prometheus or grafana repo?

[mattdurham]

Grafana though at some point we will get the changes merged upstream.

[MarkDordoy]

@mattdurham ok cool, for now I've added the update into the grafana fork, PR here: grafana/windows_exporter#21

if/when you merge that, I'll create a new PR to update the commit in the agent.

Thanks

[github-actions]

This PR has not had any activity in the past 30 days, so the needs-attention label has been added to it.
If you do not have enough time to follow up on this PR or you think it's no longer relevant, consider closing it.
The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your PR will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!

[mattdurham]

closing this since we have updated windows exporter and no longer need the grafana fork