Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Migrating from Grafana Agent Operator to Flow #5259
Docs: Migrating from Grafana Agent Operator to Flow #5259
Changes from 14 commits
0102c60
e5618e8
fab2321
c6d748f
d8b2155
7967605
0cffa43
fbc8ed1
ac297ee
187affe
b124517
69b2273
22fe64f
ce85ab7
f1ffefd
c95705c
71afe3d
34607ea
92803d9
76870b8
e21092c
9cd48af
09970bf
e0217ef
ad9f319
bb4f1ff
64bea6e
cd9fec1
6a65ee5
9a9781a
e3e359f
5b9ce16
0cc95d6
252494d
adf2cb6
cca35da
efb60c9
0858a8f
4edc051
e846b71
f24397f
88f2f84
3afc7e3
a8c572a
2893983
2c7734d
c280e3a
0f8024e
aca0c63
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be good to link to the guide for migrating static configs to flow ones, e.g.:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also add an example of agent flow config? If in the first step were are showing an snippet with an specific config example, why not here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If they're operator users, they won't have directly interacted with static config, so I'm not sure how relevant that is. Since all the config comes from crds, there isn't any real "initial config", other than what they add below to correspond with a metrics instance. Maybe I can clarify that at least.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to mention here
loki.source.kubernetes_events
as it was an integration that was not an exporter? WDYT here documentingprometheus.exporter
component configured to run in combination withMetricsIntances
replacements?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MetricsInstance didn't specify any integrations, there was a seperate CRD for that which took pretty free-form arguments. What if we added an info box on the static mode integration pages that linked to the matching flow component?