-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new options to spanmetrics processor in static mode: #5407
Add new options to spanmetrics processor in static mode: #5407
Conversation
c408bee
to
a7e44f6
Compare
@tpaschalis thank you for the review, and apologies for the silly errors! Btw I see that we seem to have a practice to list supported values like this:
I didn't do this for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doc input is minimal. OK as-is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
a7e44f6
to
4a50bcc
Compare
* aggregation_temporality * metrics_flush_interval
dd7f5c3
to
8d63542
Compare
PR Description
Adding new config options to spanmetrics processor in static mode:
aggregation_temporality
: configures whether to reset the metrics after flushing.metrics_flush_interval
: configures how often to flush generated metrics.Which issue(s) this PR fixes
Fixes #4614
Notes to the Reviewer
This change is ok from a feature parity point of view because both of these config options are present in otelcol.connector.spanmetrics.
PR Checklist