Added last read/wrote timestamp metrics to loki.write #5699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thepalbi
force-pushed
the
pablo/loki-write-more-metrics
branch
from
b019fbe to
d12d812
Compare
tpaschalis
reviewed
Nov 7, 2023
tpaschalis
reviewed
Nov 7, 2023
|
@tpaschalis all fixed |
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR adds two new metrics to the WAL enabled
loki.write:This will allow us to track the delay between the WAL writing and reading side, in actual time from the entries flowing through the WAL.
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist