Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simple clustering support for loki.source.kubernetes_events #5725

Closed
wants to merge 3 commits into from

Conversation

captncraig
Copy link
Contributor

This implements clustering by simply distributing each namespace (or the only namespace for all when "" is given) to a different node.

As I submit this I realize there could be a problem since the positions will be stored locally, so if the clustering changes, the new owner could try to catch up. That may need a little thought.

@captncraig captncraig requested review from a team and clayton-cornell as code owners November 6, 2023 20:02
@rfratto
Copy link
Member

rfratto commented Nov 10, 2023

As discussed offline, this is a case where grafana/alloy#399 would be a more appropriate solution rather than adding a clustering block to loki.source.kubernetes_events; it's not clear if even significantly large clusters have so much event volume that it makes sense to shard event handling across multiple nodes.

For now, we'll continue to defer deduplication of logs to Loki while we wait for grafana/alloy#399 to be available.

I'm closing this for now, but we can revisit later if our knowledge about loki.source.kubernetes_events changes.

@rfratto rfratto closed this Nov 10, 2023
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants