Import statement for module 2.0 experiment #5890
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattdurham
reviewed
Nov 30, 2023
thampiotr
reviewed
Dec 1, 2023
| } | ||
|
|
||
| // Arguments holds values which are used to configure the module. | ||
| type Arguments = map[string]any |
There was a problem hiding this comment.
Would this trick also work for exports? Right now I think you'd need to get exports via namespace.comp_name.exports.something instead of namespace.compo_name.something.
There was a problem hiding this comment.
nice one, yes that should work. I tried it with unit tests and it worked :)
| @@ -239,6 +244,17 @@ func (l *Loader) Apply(args map[string]any, componentBlocks []*ast.BlockStmt, co | |||
| return diags | |||
| } | |||
|
|
|||
| func (l *Loader) onImportContentChange(importLabel string, content string) { | |||
There was a problem hiding this comment.
I think we have a few other options for how the updates to contents of an import can be populated and some of them may alleviate many of the issues that you mention in the comments. Let's discuss on our call.
| diags.Add(diag.Diagnostic{ | ||
| Severity: diag.SeverityLevelError, | ||
| Message: fmt.Sprintf("Unrecognized component name %q", componentName), | ||
| Message: fmt.Sprintf("Explicitly creating a %q in a river file is not allowed", componentName), |
There was a problem hiding this comment.
Maybe we could be not adding this component to registry at all. It's already quite special.
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR implements the import statement defined in this doc. The implementation is based on the current module implementation and differs from the approach tested in #5842.
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist