Docs/correct discover kubernetes constants example #5900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clayton-cornell
added
the
type/docs
clayton-cornell
deleted the
docs/correct-discover-kubernetes-constants-example
branch
grafanabot
pushed a commit
that referenced
this pull request
Nov 30, 2023
* Update example limiting pods on the same node * Update example syntax * Add note about helm chart * Minor syntax tidy (cherry picked from commit 0ecc190)
clayton-cornell
added a commit
that referenced
this pull request
Nov 30, 2023
* Update example limiting pods on the same node * Update example syntax * Add note about helm chart * Minor syntax tidy (cherry picked from commit 0ecc190) Co-authored-by: Clayton Cornell <[email protected]>
BarunKGP
pushed a commit
to BarunKGP/grafana-agent
that referenced
this pull request
Feb 20, 2024
* Update example limiting pods on the same node * Update example syntax * Add note about helm chart * Minor syntax tidy
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR corrects the example in
dicsovery.kubernetesand adds a note about it only working in the Helm chart deployment.This PR fixes a question raised in an old issue: #2703
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist