Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explain tracing load balancing in more detail #5904

Merged
merged 9 commits into from
Jan 10, 2024
Merged

Explain tracing load balancing in more detail #5904

merged 9 commits into from
Jan 10, 2024

Conversation

ptodev
Copy link
Contributor

@ptodev ptodev commented Dec 1, 2023

When load balancing traces over multiple Agent instances, there are lots of potential issues that our users need to watch out for. These docs updates go into detail and provide examples.

Some things are still not complete:

  • I still have to add some more info regarding Static mode.
  • Ideally we could also add pictures with the architecture.
  • I need to make a working Static config which uses the Kubernetes resolver.
  • I'm still not sure if the locations in the docs which I edited are the most appropriate ones. Especially the "Deploy Grafana Agent" page.

@ptodev ptodev linked an issue Dec 1, 2023 that may be closed by this pull request
Write a documentation page on scaling traces pipelines #5253
Closed
thampiotr
thampiotr reviewed Dec 1, 2023
View reviewed changes
Copy link
Contributor

@thampiotr thampiotr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass, this is pretty large, would be good to figure out how to make it more brief and less repetitive, because as the way things work in OTEL change, we'd have more and more docs to properly maintain.

docs/sources/flow/reference/components/otelcol.exporter.loadbalancing.md Outdated Show resolved Hide resolved
docs/sources/flow/reference/components/otelcol.exporter.loadbalancing.md Outdated Show resolved Hide resolved
docs/sources/flow/reference/components/otelcol.exporter.loadbalancing.md Outdated Show resolved Hide resolved
docs/sources/flow/reference/components/otelcol.exporter.loadbalancing.md Outdated Show resolved Hide resolved
docs/sources/flow/reference/components/otelcol.exporter.loadbalancing.md Outdated Show resolved Hide resolved
docs/sources/flow/setup/deploy-agent.md Outdated Show resolved Hide resolved
docs/sources/flow/setup/deploy-agent.md Outdated Show resolved Hide resolved
docs/sources/static/configuration/traces-config.md Outdated Show resolved Hide resolved
docs/sources/static/configuration/traces-config.md Outdated Show resolved Hide resolved
docs/sources/static/set-up/deploy-agent.md Show resolved Hide resolved
@ptodev ptodev force-pushed the 5253-write-a-documentation-page-on-scaling-traces-pipelines branch 2 times, most recently from a9f2c01 to d889c0e Compare December 8, 2023 12:29
@ptodev ptodev requested a review from thampiotr December 8, 2023 12:33
thampiotr
thampiotr approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@thampiotr thampiotr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it! We can always improve these docs, but it's important for users to have them.

docs/sources/flow/reference/components/otelcol.exporter.loadbalancing.md Outdated Show resolved Hide resolved
docs/sources/flow/setup/deploy-agent.md Outdated Show resolved Hide resolved
docs/sources/flow/setup/deploy-agent.md Show resolved Hide resolved
@ptodev ptodev marked this pull request as ready for review December 8, 2023 15:43
@clayton-cornell clayton-cornell added the type/docs Docs Squad label across all Grafana Labs repos label Dec 8, 2023
clayton-cornell
clayton-cornell reviewed Dec 8, 2023
View reviewed changes
docs/sources/flow/reference/components/otelcol.exporter.loadbalancing.md Outdated Show resolved Hide resolved
docs/sources/flow/reference/components/otelcol.exporter.loadbalancing.md Outdated Show resolved Hide resolved
docs/sources/flow/reference/components/otelcol.exporter.loadbalancing.md Outdated Show resolved Hide resolved
docs/sources/flow/reference/components/otelcol.exporter.loadbalancing.md Outdated Show resolved Hide resolved
docs/sources/flow/reference/components/otelcol.exporter.loadbalancing.md Outdated Show resolved Hide resolved
docs/sources/flow/setup/deploy-agent.md Outdated Show resolved Hide resolved
docs/sources/flow/setup/deploy-agent.md Outdated Show resolved Hide resolved
docs/sources/flow/setup/deploy-agent.md Outdated Show resolved Hide resolved
docs/sources/flow/setup/deploy-agent.md Outdated Show resolved Hide resolved
docs/sources/flow/setup/deploy-agent.md Outdated Show resolved Hide resolved
@ptodev ptodev force-pushed the 5253-write-a-documentation-page-on-scaling-traces-pipelines branch from c05c45e to 4e04c29 Compare January 8, 2024 11:40
@ptodev ptodev requested a review from clayton-cornell January 9, 2024 10:58
@ptodev
Copy link
Contributor Author

ptodev commented Jan 9, 2024

Hi, @clayton-cornell, thank you for the comments! I updated this PR following your feedback, and it is ready for review again.

@ptodev ptodev merged commit f696b3a into main Jan 10, 2024
10 checks passed
@ptodev ptodev deleted the 5253-write-a-documentation-page-on-scaling-traces-pipelines branch January 10, 2024 07:21
BarunKGP pushed a commit to BarunKGP/grafana-agent that referenced this pull request Feb 20, 2024
@ptodev @thampiotr
@clayton-cornell @BarunKGP
Explain tracing load balancing in more detail (grafana#5904)
b2dff9b 
* Explain tracing load balancing in more detail

---------

Co-authored-by: Piotr <[email protected]>
Co-authored-by: Clayton Cornell <[email protected]>
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thampiotr thampiotr thampiotr approved these changes

@clayton-cornell clayton-cornell Awaiting requested review from clayton-cornell clayton-cornell is a code owner

Assignees

@thampiotr thampiotr

@clayton-cornell clayton-cornell

Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write a documentation page on scaling traces pipelines
3 participants
@ptodev @thampiotr @clayton-cornell