remote/http: add an optional request body #5918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paschalis Tsilias <[email protected]>
|
Doc change is fine. The code looks OK to my eye, but... I'll leave that to someone who knows Go better than I do :-) |
clayton-cornell
added
the
type/docs
Signed-off-by: Paschalis Tsilias <[email protected]>
ptodev
approved these changes
Dec 8, 2023
BarunKGP
pushed a commit
to BarunKGP/grafana-agent
that referenced
this pull request
Feb 20, 2024
Signed-off-by: Paschalis Tsilias <[email protected]>
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR changes remote.http to add an optional request body. The component allows to perform POST/PUT/PATCH requests, but doing them without a body is not super useful.
Which issue(s) this PR fixes
No PR filed.
Notes to the Reviewer
PR Checklist