feat(exporter/windows): expose physical_disk collector #5927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
|
We should decide a policy going forward on it. Technically we have said that changing metrics is not a breaking change. Do we have a feel for how many metrics it creates? |
|
There are 11 new metrics if this is enabled by default. |
docs/sources/static/configuration/integrations/windows-exporter-config.md
Outdated
Show resolved
Hide resolved
docs/sources/static/configuration/integrations/windows-exporter-config.md
Outdated
Show resolved
Hide resolved
clayton-cornell
added
the
type/docs
…r-config.md Co-authored-by: Clayton Cornell <[email protected]>
…r-config.md Co-authored-by: Clayton Cornell <[email protected]>
|
Looks good enabled automerge once conflicts are resolved. |
clayton-cornell
approved these changes
Jan 10, 2024
|
@mattdurham Automerge can't complete... there are conflicts. I've tried a quick resolve. |
mattdurham
reviewed
Jan 11, 2024
adding a comma
BarunKGP
pushed a commit
to BarunKGP/grafana-agent
that referenced
this pull request
Feb 20, 2024
* feat(exporter/windows): expose physical_disk collector Signed-off-by: hainenber <[email protected]> * fix(exporter/windows): correct river attr name for physical_disk Signed-off-by: hainenber <[email protected]> * feat(exporter/windows): set default args for physical_disk attr Signed-off-by: hainenber <[email protected]> * feat(exporter/windows): update unit test + integration doc Signed-off-by: hainenber <[email protected]> * Update docs/sources/static/configuration/integrations/windows-exporter-config.md Co-authored-by: Clayton Cornell <[email protected]> * Update docs/sources/static/configuration/integrations/windows-exporter-config.md Co-authored-by: Clayton Cornell <[email protected]> --------- Signed-off-by: hainenber <[email protected]> Co-authored-by: Clayton Cornell <[email protected]>
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Which issue(s) this PR fixes
Fixes #5882
Notes to the Reviewer
The new collector is set as default by
windows_exporter. Should we follow the course or keep it as non-default to keep it simpler?PR Checklist