Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix windows tests 2 #5932

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Fix windows tests 2 #5932

merged 2 commits into from
Dec 7, 2023

Conversation

erikbaranowski
Copy link
Contributor

@erikbaranowski erikbaranowski commented Dec 7, 2023 •
edited
Loading

PR Description

Fixes windows test failures introduced by #5784 and #5791

Which issue(s) this PR fixes

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

thampiotr
thampiotr approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@thampiotr thampiotr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

@erikbaranowski erikbaranowski merged commit 394721e into main Dec 7, 2023
8 checks passed
@erikbaranowski erikbaranowski deleted the fix-windows-tests-2 branch December 7, 2023 23:14
BarunKGP pushed a commit to BarunKGP/grafana-agent that referenced this pull request Feb 20, 2024
@erikbaranowski @BarunKGP
Fix windows tests 2 (grafana#5932)
08241a0
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thampiotr thampiotr thampiotr approved these changes

Assignees

@mattdurham mattdurham

@thampiotr thampiotr

Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erikbaranowski @thampiotr @mattdurham