chore(deps): remove minio dependency #5933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptodev
approved these changes
Dec 8, 2023
| // supports '*' and '?' wildcards in the pattern string. | ||
| // unlike path.Match(), considers a path as a flat name space while matching the pattern. | ||
| // The difference is illustrated in the example here https://play.golang.org/p/Ega9qgD4Qz . | ||
| func Match(pattern, name string) (matched bool) { |
There was a problem hiding this comment.
The comment above talks about a "text", whereas the function's input variable is "name". It'd be nice if both the comment and the function are using the same name.
Comment on lines
+66
to
+67
| str = str[1:] | ||
| pattern = pattern[1:] |
There was a problem hiding this comment.
This seems a bit inefficient? I suppose performance is not important in this case?
Comment on lines
+374
to
+377
| actualResult := wildcard.Match(testCase.pattern, testCase.text) | ||
| if testCase.matched != actualResult { | ||
| t.Errorf("Test %d: Expected the result to be `%v`, but instead found it to be `%v`", i+1, testCase.matched, actualResult) | ||
| } |
There was a problem hiding this comment.
Suggested change
| actualResult := wildcard.Match(testCase.pattern, testCase.text) | |
| if testCase.matched != actualResult { | |
| t.Errorf("Test %d: Expected the result to be `%v`, but instead found it to be `%v`", i+1, testCase.matched, actualResult) | |
| } | |
| t.Run(fmt.Sprintf("%d", i+1), func(t *testing.T) { | |
| actualResult := wildcard.Match(testCase.pattern, testCase.text) | |
| require.Equal(t, actualResult, testCase.matched) | |
| }) |
It's a personal preference, but I'd prefer something like this.
BarunKGP
pushed a commit
to BarunKGP/grafana-agent
that referenced
this pull request
Feb 20, 2024
* remove minio dependency * gofmt
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Turns out vendored minio dep used for faro receiver has AGPL license. This PR removes the dependency, instead copying in relevant code from older Apache licenesed version of minio.
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist