Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for static mode extra-args #5989

Merged
merged 1 commit into from
Dec 15, 2023
Merged

fix for static mode extra-args #5989

merged 1 commit into from
Dec 15, 2023

Conversation

erikbaranowski
Copy link
Contributor

PR Description

Which issue(s) this PR fixes

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@erikbaranowski
fix for static mode extra-args
898508a 
Signed-off-by: erikbaranowski <[email protected]>
@erikbaranowski erikbaranowski marked this pull request as ready for review December 15, 2023 20:10
@erikbaranowski erikbaranowski merged commit a215d1b into main Dec 15, 2023
8 checks passed
@erikbaranowski erikbaranowski deleted the converter-fix-extra-args-parsing branch December 15, 2023 20:20
mattdurham
mattdurham approved these changes Dec 15, 2023
View reviewed changes
Copy link
Collaborator

@mattdurham mattdurham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

BarunKGP pushed a commit to BarunKGP/grafana-agent that referenced this pull request Feb 20, 2024
@erikbaranowski @BarunKGP
fix for static mode extra-args (grafana#5989)
38921f9 
Signed-off-by: erikbaranowski <[email protected]>
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattdurham mattdurham mattdurham approved these changes

@captncraig captncraig captncraig approved these changes

Assignees

@mattdurham mattdurham

Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erikbaranowski @captncraig @mattdurham